refactor(routing): Remove backwards compatibility for the routing crate #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aprabhat19
added
S-waiting-on-review
…perswitch into rmove-backwards-compat
…h into rmove-backwards-compat
…h into rmove-backwards-compat
2 tasks
vspecky
requested changes
Jul 17, 2024
crates/api_models/src/routing.rs
Outdated
Comment on lines
168
to
185
| pub enum RoutableChoiceKind { | ||
| OnlyConnector, | ||
| FullStruct, | ||
| } | ||
|
|
||
| #[cfg(feature = "connector_choice_bcompat")] | ||
| #[derive(Debug, serde::Deserialize, serde::Serialize)] | ||
| #[serde(untagged)] | ||
| pub enum RoutableChoiceSerde { | ||
| OnlyConnector(Box<RoutableConnectors>), | ||
| FullStruct { | ||
| connector: RoutableConnectors, | ||
| #[cfg(feature = "connector_choice_mca_id")] | ||
| merchant_connector_id: Option<String>, | ||
| #[cfg(not(feature = "connector_choice_mca_id"))] | ||
| sub_label: Option<String>, | ||
| }, | ||
| } |
There was a problem hiding this comment.
We still need support for both types of data (OnlyConnector & FullStruct), as per our current standing. We may take a call to remove support for OnlyConnector in the future, but that will most probably require DB migrations.
There was a problem hiding this comment.
Will remove these fields and open a separate PR
…perswitch into rmove-backwards-compat
SanchithHegde
previously approved these changes
Jul 17, 2024
Co-authored-by: Shanks <[email protected]>
SanchithHegde
approved these changes
Jul 18, 2024
jarnura
approved these changes
Jul 18, 2024
ivor11
approved these changes
Jul 18, 2024
ivor11
approved these changes
Jul 18, 2024
pixincreate
removed
the
S-waiting-on-review
pixincreate
added a commit
that referenced
this pull request
Jul 19, 2024
* 'main' of github.com:juspay/hyperswitch: (26 commits) refactor(core): change primary keys in user, user_roles and roles tables (#5374) chore(version): 2024.07.19.1 refactor(connector): make the `original_authorized_amount` optional for MITs with `connector_mandate_details` (#5311) feat(connector): Plaid connector Integration (#3952) feat: encryption service integration to support batch encryption and decryption (#5164) refactor(core): change primary key of refund table (#5367) chore(version): 2024.07.19.0 chore(postman): update Postman collection files Docs: Updating Error codes for documentation purposes (#5314) fix(core): [payouts] failure of payout retrieve when token is expired (#5362) build: remove unused dependencies (#5343) refactor(blocklist): change primary key of blocklist table (#5356) chore: Increasing log coverage for payment method list (#5042) refactor(routing): Remove backwards compatibility for the routing crate (#3015) refactor(merchant_account): change primary key for merchant account (#5327) refactor(router): remove id dependency from merchant connector account, dispute and mandate (#5330) feat(connector): [Itau Bank] Template for payment flows (#5304) chore(version): 2024.07.18.0 refactor(router): Remove the locker call in the psync flow (#5348) feat(router): Add support for passing the domain dynamically in the session call (#5347) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Remove the feature flags that were added for providing support for backwards compatibility.
Additional Changes
Motivation and Context
How did you test it?
This PR cannot be tested as it removes the support for backwards compatibility. A sanity for routing must be done.
Checklist
cargo +nightly fmt --allcargo clippy